Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h

From: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Date: Aug 18, 2009, 20:29 UTC
Message-ID: <08Paa_FqYXS4u78q8DsW-e7xpWkmcOdrkJUSHb8zhns8DwkPS-Rpxw@cipher.nrlssc.navy.mil>
In-Reply-To: <alpine.LFD.2.00.0908181607240.6044@xanadu.home>

Nicolas Pitre wrote:

Show 13 quoted lines

> On Tue, 18 Aug 2009, Brandon Casey wrote:
> 
>> The SUNWspro compiler doesn't set __i386__.  Instead it sets __i386, and
>> I think __x86_64 and __amd64 where appropriate.  So, compilation with
>> the SUNWspro compiler on x86 is currently unaffected by these changes and
>> falls back to the generic routines.
>>
>> It seems that v5.10 of the compiler can grok both the __asm__ statements
>> and the ({...}) naked block notation and passes all of the tests when the
>> block_sha1 code is modified to add defined(__i386) to each of the macro
>> statements.
> 
> Does it really implement the gcc inline assembly syntax?

Yes, I think it does. I actually extracted the assembly from sha1.c and tested in a separate test program. The v5.10 sunwspro compiler compiles and executes it correctly.

-brandon