git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] commit-graph: more leak fixes

From
Derrick Stolee <stolee@gmail.com>
Date
Oct 3, 2018, 16:19 UTC
Message-ID
<07aa3628-f651-3a8f-21b4-b66099de864c@gmail.com>
In-Reply-To
<cover.1538579441.git.martin.agren@gmail.com>
On 10/3/2018 11:36 AM, Martin Ågren wrote:
Show 5 quoted lines
> Hi Derrick,
>
> These two patches on top of yours make the test suite (i.e., the subset
> of it that I run) leak-free with respect to builtin/commit-graph.c and
> commit-graph.c.
Thanks!
> The first could be squashed into your patch 1/2. It touches the same
> function, but it requires a different usage to trigger, so squashing it
> in would require broadening the scope. I understand if you don't want to
> do that.

I'm fine with squashing it in with both our sign-offs. It is the same idea, it just requires a different set of arguments to hit it. I'll adjust the commit message as necessary.

> If you want to pick these up as part of your re-roll in any way, shape
> or form, go ahead. If not, they can go in separately, either in parallel
> or after your series lands. Whatever the destiny of this posting, I'll
> follow through as appropriate.
I'll add your PATCH 2/2 to my v2. Thanks!
Previous: Martin ÅgrenNext: Martin Ågren
Message 13 of 20 in “Clean up leaks in commit-graph.c”
  1. 0/2 Clean up leaks in commit-graph.cDerrick Stolee via GitGitGadget, Oct 2, 2018
  2. 1/2 commit-graph: clean up leaked memory during writeDerrick Stolee via GitGitGadget, Oct 2, 2018
  3. Martin ÅgrenOct 2, 2018
  4. Stefan BellerOct 2, 2018
  5. Martin ÅgrenOct 2, 2018
  6. Stefan BellerOct 2, 2018
  7. Jeff KingOct 2, 2018
  8. Stefan BellerOct 2, 2018
  9. Derrick StoleeOct 3, 2018
  10. 0/2 commit-graph: more leak fixesMartin Ågren, Oct 3, 2018
  11. 1/2 commit-graph: free `struct packed_git` after closing itMartin Ågren, Oct 3, 2018
  12. 2/2 builtin/commit-graph.c: UNLEAK variablesMartin Ågren, Oct 3, 2018
  13. Derrick StoleeOct 3, 2018
  14. Martin ÅgrenOct 3, 2018
  15. Jeff KingOct 2, 2018
  16. 2/2 commit-graph: reduce initial oid allocationDerrick Stolee via GitGitGadget, Oct 2, 2018
  17. 0/3 Clean up leaks in commit-graph.cDerrick Stolee via GitGitGadget, Oct 3, 2018
  18. 1/3 commit-graph: clean up leaked memory during writeDerrick Stolee via GitGitGadget, Oct 3, 2018
  19. 2/3 builtin/commit-graph.c: UNLEAK variablesMartin Ågren via GitGitGadget, Oct 3, 2018
  20. 3/3 commit-graph: reduce initial oid allocationDerrick Stolee via GitGitGadget, Oct 3, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.