git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] Fix memory corruption with FSMonitor-enabled unpack_trees()

From
Derrick Stolee <stolee@gmail.com>
Date
Mar 17, 2021, 20:21 UTC
Message-ID
<07a368ee-6b45-a401-32c3-c052370150f5@gmail.com>
In-Reply-To
<pull.891.git.1615995049.gitgitgadget@gmail.com>
On 3/17/2021 11:30 AM, Johannes Schindelin via GitGitGadget wrote:
> While dog-fooding Jeff Hostetler's FSMonitor patches, I ran into a really
> obscure segmentation fault during one of my epic Git for Windows rebases.
Thanks for dogfooding!
> Turns out that this bug is quite old.
A little over a year, yes, since the v2 hook was committed. It's old
enough that these could be applied to 'maint'.
 
> Johannes Schindelin (2):
>   fsmonitor: fix memory corruption in some corner cases
>   fsmonitor: do not forget to release the token in `discard_index()`

The patches themselves are correct and describe the problem well. They only show up during non-trivial uses of FS Monitor and index updates, so I understand your hesitance to write tests that trigger these problems.

Thanks, -Stolee

Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 5 of 6 in “Fix memory corruption with FSMonitor-enabled unpack_trees()”
  1. 0/2 Fix memory corruption with FSMonitor-enabled unpack_trees()Johannes Schindelin via GitGitGadget, Mar 17, 2021
  2. 1/2 fsmonitor: fix memory corruption in some corner casesJohannes Schindelin via GitGitGadget, Mar 17, 2021
  3. Junio C HamanoMar 17, 2021
  4. 2/2 fsmonitor: do not forget to release the token in `discard_index()`Johannes Schindelin via GitGitGadget, Mar 17, 2021
  5. Derrick StoleeMar 17, 2021
  6. Johannes SchindelinMar 19, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.