Re: [PATCH 02/23] read-cache: fix leaking hash context in `do_write_index()`
- From
Derrick Stolee <stolee@gmail.com>
- Date
- Sep 30, 2024, 14:05 UTC
- Message-ID
- <076932a7-d88d-4aea-8117-69a2ab83f459@gmail.com>
- In-Reply-To
- <c51f40c5bd0c56967e348363e784222de7884b79.1727687410.git.ps@pks.im>
On 9/30/24 5:13 AM, Patrick Steinhardt wrote:
Show 24 quoted lines
> When writing an index with the EOIE extension we allocate a separate > hash context. We never free that context though, causing a memory leak. > Plug it. > > This leak is exposed by t9210, but plugging it alone does not make the > whole test suite pass. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > read-cache.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/read-cache.c b/read-cache.c > index 764fdfec46..0fb5e0d372 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -3124,6 +3124,7 @@ static int do_write_index(struct index_state *istate, struct tempfile *tempfile, > if (f) > free_hashfile(f); > strbuf_release(&sb); > + free(eoie_c); > free(ieot); > return ret; > }
Thank you for finding and fixing this! This version should be used instead of the similar patch I sent today.
Thanks, -Stolee