[PATCH v2 02/11] add -i (built-in): send error messages to stderr
- From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
- Date
- Nov 11, 2020, 12:28 UTC
- Message-ID
- <068813912b9e5133f9d9bbacb239f7954788bf53.1605097704.git.gitgitgadget@gmail.com>
- In-Reply-To
- <pull.785.v2.git.1605097704.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>
The Perl version of that command already does that since a301973641f (add -p: print errors in separate color, 2009-02-05). The built-in version's development started by reimplementing the initial version from 5cde71d64af (git-add --interactive, 2006-12-10) for simplicity, though, which still printed error messages to stdout.
Let's fix that by imitating the Perl version's behavior in the built-in version of that command.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> --- add-interactive.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/add-interactive.c b/add-interactive.c index 8ca503d803..0f24992ca4 100644 --- a/add-interactive.c +++ b/add-interactive.c @@ -365,7 +365,7 @@ static ssize_t list_and_choose(struct add_i_state *s, if (from < 0 || from >= items->items.nr || (singleton && from + 1 != to)) { - color_fprintf_ln(stdout, s->error_color, + color_fprintf_ln(stderr, s->error_color, _("Huh (%s)?"), p); break; } else if (singleton) {
-- gitgitgadget