Re: [PATCH] am: add --check option

From: René Scharfe <l.s.r@web.de>
Date: Jun 4, 2019, 15:37 UTC
Message-ID: <0683d141-544e-12da-17ae-dc1157a2985b@web.de>
In-Reply-To: <20190603142523.3826-1-sir@cmpwn.com>

Am 03.06.19 um 16:25 schrieb Drew DeVault:

Show 10 quoted lines

> @@ -2195,6 +2206,8 @@ int cmd_am(int argc, const char **argv, const char *prefix)
>  			0, PARSE_OPT_NONEG),
>  		OPT_BOOL('c', "scissors", &state.scissors,
>  			N_("strip everything before a scissors line")),
> +		OPT_BOOL(0, "check", &state.check,
> +			N_("instead of applying the patch, see if the patch is applicable")),
>  		OPT_PASSTHRU_ARGV(0, "whitespace", &state.git_apply_opts, N_("action"),
>  			N_("pass it through git-apply"),
>  			0),
>

Git apply has a --check option as well for the same purpose. Other commands have an equivalent option called --dry-run instead. Would it make sense to move towards the latter for greater consistency?

René