Re: t5539 broken under Mac OS X

From: Kyle J. McKay <mackyle@gmail.com>
Date: Jan 15, 2015, 05:48 UTC
Message-ID: <064010B3-BC58-42F2-B5C0-DAADAA59B87D@gmail.com>
In-Reply-To: <20150114211712.GE1155@peff.net>

On Jan 14, 2015, at 13:17, Jeff King wrote:

Show 28 quoted lines

> On Wed, Jan 14, 2015 at 08:50:47PM +0100, Torsten Bögershausen wrote:
>
>> But, why does e.g. t0004 behave more gracefully (and skips) and  
>> t5539 just dies ?
>>
>> ./t0004-unwritable.sh
>> ok 1 - setup
>> ok 2 # skip write-tree should notice unwritable repository (missing  
>> SANITY of POSIXPERM,SANITY)
>
> The http code uses test_skip_or_die when it runs into setup errors.  
> The
> intent there is that the user has either:
>
>  1. Told us explicitly that they want http tests by setting
>     GIT_TEST_HTTPD=true.
>
>  2. Wants to run http tests if they can by setting GIT_TEST_HTTPD=auto
>     (or leaving it unset, as that is the default).
>
> In case (1), we treat this as a test failure. They asked for httpd
> tests, and we could not run them. In case (2), we would just skip  
> all of
> the tests.
>
> You may want to loosen your GIT_TEST_HTTPD setting (pre-83d842dc, you
> had to set it to true to run the tests at all, but nowadays we have
> auto).

I ran into this problem. It seems like (at least on older Mac OS X) that the root directory is created like so:

   drwxrwxr-t  39 root  admin  /

And since the first (and likely only user) on Mac OS X is a member of the admin group, the SANITY test fails and complains even though you're not running as root (the failure message is misleading).

I ended up removing group write permission from / (which happened to find a bug in another script of mine) and then it was happy.

-Kyle