git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 7/9] treewide: use get_all_packs

From
Derrick Stolee <stolee@gmail.com>
Date
Aug 21, 2018, 13:56 UTC
Message-ID
<05f42490-bf11-8673-61db-e0afd04af43a@gmail.com>
In-Reply-To
<CAGZ79kZFXof091d4qXUVyLJ9wGPL0sfs9XruZ-3Hjoq74-tjCg@mail.gmail.com>
On 8/20/2018 6:01 PM, Stefan Beller wrote:
Show 10 quoted lines
> On Mon, Aug 20, 2018 at 9:52 AM Derrick Stolee <dstolee@microsoft.com> wrote:
>> There are many places in the codebase that want to iterate over
>> all packfiles known to Git. The purposes are wide-ranging, and
>> those that can take advantage of the multi-pack-index already
>> do. So, use get_all_packs() instead of get_packed_git() to be
>> sure we are iterating over all packfiles.
> So get_packed_git shouold not be used any further?
> Do we want to annotate it as deprecated, to be deleted
> in the future? Or even remove it as part of this series
> (that might be an issue with other series in flight).

Perhaps the right thing to do would be to put a big warning over the definition to say "only use this if you really don't want get_all_packs()" or something. The reason I didn't remove it from packfile.h is that it is used in sha1-name.c alongside get_multi_pack_index() (so making it 'static' would be incorrect).

Previous: Stefan BellerNext: Derrick Stolee
Message 11 of 18 in “multi-pack-index cleanups”
  1. 0/9 multi-pack-index cleanupsDerrick Stolee, Aug 20, 2018
  2. 1/9 multi-pack-index: provide more helpful usage infoDerrick Stolee, Aug 20, 2018
  3. 3/9 midx: mark bad packed objectsDerrick Stolee, Aug 20, 2018
  4. Stefan BellerAug 20, 2018
  5. Derrick StoleeAug 21, 2018
  6. 4/9 midx: stop reporting garbageDerrick Stolee, Aug 20, 2018
  7. 5/9 midx: fix bug that skips midx with alternatesDerrick Stolee, Aug 20, 2018
  8. 6/9 packfile: add all_packs listDerrick Stolee, Aug 20, 2018
  9. 7/9 treewide: use get_all_packsDerrick Stolee, Aug 20, 2018
  10. Stefan BellerAug 20, 2018
  11. Derrick StoleeAug 21, 2018
  12. 2/9 multi-pack-index: store local propertyDerrick Stolee, Aug 20, 2018
  13. Stefan BellerAug 20, 2018
  14. 8/9 midx: test a few commands that use get_all_packsDerrick Stolee, Aug 20, 2018
  15. Stefan BellerAug 20, 2018
  16. 9/9 pack-objects: consider packs in multi-pack-indexDerrick Stolee, Aug 20, 2018
  17. Duy NguyenAug 21, 2018
  18. Derrick StoleeAug 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.