Re: [PATCH 0/2] Squash leaks in t0000
- From
Andrzej Hunt <andrzej@ahunt.org>
- Date
- Sep 19, 2021, 15:38 UTC
- Message-ID
- <05754f9c-cd58-30f5-e2d3-58b9221d2770@ahunt.org>
- In-Reply-To
- <CAPUEspjjBAr07VB7XqGFVXDcKWkkX4OUTCxUf+VJaEAX8KTAyw@mail.gmail.com>
On 18/09/2021 19:28, Carlo Arenas wrote:
Show 14 quoted lines
> >> Here's a series that I've sat on for a while, which adds some UNLEAK's to >> "fix" this situation - see the individual patches for a justification of why >> an UNLEAK seems appropriate. > > While I see that UNLEAK in this specific case, might be an ok "fix", I > have to admit that not finding a repo_clear_revisions() (or equivalent > function) that could be used to clear revs seems like a problem worth > fixing as well for the future. > > Will reply with my WIP so we can see if it could work either as an > alternative to this, or at least lay some foundations so that a long > running process that needs to use a `struct revision` or some of this > logic can in the future without having to deal with leaks.
Great - in this case I think it's best to ignore my patches since actually fixing the leaks is obviously a better solution :) !
ATB,
Andrzej