Re: [PATCH] grep: fix multibyte regex handling under macOS

From: Diomidis Spinellis <dds@aueb.gr>
Date: Aug 24, 2022, 05:13 UTC
Message-ID: <05275758-2b69-a4bd-30ca-4d48cbfe39f5@aueb.gr>
In-Reply-To: <CAPig+cSf+Gi4cHQLcTenxH=RzBxxqCApKhFTkCUMAS=0fYXZDA@mail.gmail.com>

On 23-Aug-22 23:40, Eric Sunshine wrote:

Show 9 quoted lines

> On Tue, Aug 23, 2022 at 4:04 PM Diomidis Spinellis via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>> diff --git a/t/t7818-grep-multibyte.sh b/t/t7818-grep-multibyte.sh
>> +# Multibyte regex search is only supported with a native regex library
>> +# that supports them.
>> +# (The included library is compiled with NO_MBSUPPORT) and only if it
>> +test -z "$NO_REGEX" &&
> 
> The comment above seems incomplete (i.e. "and only if it...").

Thank you for pointing this out. I posted an update that fixes this.

Diomidis