Re: [PATCH v2] attr: teach "--attr-source=<tree>" global option to "git"

From: John Cai <johncai86@gmail.com>
Date: Mar 27, 2023, 19:40 UTC
Message-ID: <050BD3EA-8A9E-4A33-AD18-B8A132F6EF2C@gmail.com>
In-Reply-To: <xmqqcz4u9hew.fsf@gitster.g>

Hi Junio,

On 27 Mar 2023, at 14:29, Junio C Hamano wrote:

Show 8 quoted lines

> "John Cai via GitGitGadget" <gitgitgadget@gmail.com> writes:
>
>>     This version is the same as v1. Just changed the author to Junio as he
>>     contributed most of the code.
>
> Heh, I do not need an extra credit.  The most important missing
> piece I punted (i.e. the environment passing and receiving) was done
> by you that is a larger contribution anyway ;-)

Given that the main idea was yours and most of the code minus the test was as well, I thought it made the most sense.

>
> I am kind-a surprised that we haven't queued the earlier one.  Is
> this ready to ship?

I believe so, though a review wouldn't hurt--especially on the environment variable passing and receiving piece.

>
> Thanks.

thanks! John