Re: [PATCH] git-gui: do not end the commit message with an empty line

From: Johannes Sixt <j6t@kdbg.org>
Date: May 15, 2025, 05:36 UTC
Message-ID: <049648a9-5580-4214-bd00-c905127939b5@kdbg.org>
In-Reply-To: <xmqqv7q27v49.fsf@gitster.g>

Am 14.05.25 um 23:14 schrieb Junio C Hamano:

> As git-gui uses plumbing commit-tree to create the
> commit object, it has to be more careful not to have extra blank
> lines, as it cannot assume stripspace internal to "git commit"?

Correct. We had used git stripspace for about a month, introduced by b9a4386, reverted by c0698df. The reasons not to use it were old Tcl versions and MacOS. We may revisit this case after we raise version requirements.

-- Hannes