Re: Bug: rebase -i creates committer time inversions on 'reword'

From: Phillip Wood <phillip.wood@talktalk.net>
Date: Apr 19, 2018, 09:17 UTC
Message-ID: <041aabb4-4e61-30a1-2ab0-3ae1ddd47c38@talktalk.net>
In-Reply-To: <ba17074b-865e-32ba-908d-0d94bedc50ad@talktalk.net>

On 16/04/18 10:48, Phillip Wood wrote:

Show 17 quoted lines

> On 14/04/18 14:11, Johannes Schindelin wrote:
>> Hi,
>>
>> On Sat, 14 Apr 2018, Phillip Wood wrote:
>>
>> FWIW I agree with Hannes' patch.
>>
>>> I think 'git am' probably gives all patches the same commit time as well
>>> if the commit date is cached though it wont suffer from the time-travel
>>> problem.
>>
>> I thought that `git am` was the subject of such a complaint recently, but
>> I thought that had been resolved? Apparently I misremember...
> 
> I had a quick look and couldn't see anything about that, it looks to me
> like it just calls commit_tree() and only does anything to change the
> default commit date if '--committer-date-is-author-date' was given.

Ah you were right, I just didn't look far enough back in the history .(it's a shame it calls reset_ident_date() in a different function to the one that creates the commit otherwise I would probably have noticed it when I wrote the original patches)

Best Wishes

Phillip

Show 8 quoted lines

> 
> Best Wishes
> 
> Phillip
>> Ciao,
>> Dscho
>>
>