Re: [PATCH 00/13] RFC object filtering for parital clone
- From
- Jeff Hostetler <git@jeffhostetler.com>
- Date
- Sep 26, 2017, 14:55 UTC
- Message-ID
- <03a00220-f637-5931-c8f4-07833a9b3d4f@jeffhostetler.com>
- In-Reply-To
- <20170922173957.f5601015cc8d6760c80293a9@google.com>
On 9/22/2017 8:39 PM, Jonathan Tan wrote:
Show 22 quoted lines
> On Fri, 22 Sep 2017 20:26:19 +0000 > Jeff Hostetler <git@jeffhostetler.com> wrote: > >> This draft contains filters to: >> () omit all blobs >> () omit blobs larger than some size >> () omit blobs using a sparse-checkout specification >> >> In addition to specifying the filter criteria, the rev-list command >> was updated to include options to: >> () print a list of the omitted objects (due to the current filtering >> criteria) >> () print a list of missing objects (probably from a prior partial >> clone/fetch). > > Thanks, this last point seems useful. > > I tried applying your patches and it doesn't apply cleanly on master. > Could you try rebasing? In particular, the code references > get_sha1_with_context(), which no longer exists (it was replaced with > get_oid_with_context()). >
I usually build and submit patches relative to the latest available tag (v2.14.1) rather than a moving target, but yeah I'll look thru the other comments and rebase it forward.
Thanks Jeff