Re: [PATCH] archive-zip: omit UT extra field if mtime is out of range
- From
René Scharfe <l.s.r@web.de>
- Date
- Oct 12, 2026, 14:45 UTC
- Message-ID
- <0334c031-56e3-4c8d-8adc-52051d2e26aa@web.de>
- In-Reply-To
- <CA+h9NxRQLP=20kfmSm6B2WtkkmHDCfdRDZEawOpzFF1LoghTEA@mail.gmail.com>
On 10/12/26 2:56 PM, m@sph3r3.com wrote:
> Thanks for the patch. I confirmed that it fixes the 2106 case: before > the change, UT wrapped to zero and unzip -u retained the existing 2025 > file; afterward, UT is omitted and the file is replaced correctly.
Thanks for checking!
Show 8 quoted lines
> For the i386 failure Junio reported, the beyond-2038 archive test and > its dependent omission check should use TIME_T_IS_64BIT. TIME_IS_64BIT > checks Git's timestamp_t, which can be 64-bit while time_t is 32-bit. > > With that two-line adjustment, all 18 t5004 tests pass on x86-64 > Linux. Forcing TIME_T_IS_64BIT off skips only those two tests; the > other 16 pass, including both INT32_MAX checks. I haven't run a native > 32-bit build.
That would be an easy way out, nice! I suspect git archive should not even use time_t in this context, though.
René