git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t6019: avoid refname collision on case-insensitive systems

From
Thomas Rast <trast@student.ethz.ch>
Date
Sep 15, 2011, 08:34 UTC
Message-ID
<02451a2849fc8f1cab7983b6c8c629ebb6a1aaa9.1316075573.git.trast@student.ethz.ch>

The criss-cross tests kept failing for me because of collisions of 'a' with 'A' etc. Prefix the lowercase refnames with an extra letter to disambiguate.

Signed-off-by: Thomas Rast <trast@student.ethz.ch>
---

This fixes the tests on OS X. Together with Peff's fix to the poll issue, it now tests clean again.

 t/t6019-rev-list-ancestry-path.sh |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)
diff --git a/t/t6019-rev-list-ancestry-path.sh b/t/t6019-rev-list-ancestry-path.sh
index 738af73..39b4cb0 100755
--- a/t/t6019-rev-list-ancestry-path.sh
+++ b/t/t6019-rev-list-ancestry-path.sh
@@ -75,33 +75,36 @@ test_expect_success 'rev-list --ancestry-patch D..M -- M.t' '
 # a   X
 #  \ / \
 #   c---cb
+#
+# All refnames prefixed with 'x' to avoid confusion with the tags
+# generated by test_commit on case-insensitive systems.
 test_expect_success 'setup criss-cross' '
 	mkdir criss-cross &&
 	(cd criss-cross &&
 	 git init &&
 	 test_commit A &&
-	 git checkout -b b master &&
+	 git checkout -b xb master &&
 	 test_commit B &&
-	 git checkout -b c master &&
+	 git checkout -b xc master &&
 	 test_commit C &&
-	 git checkout -b bc b -- &&
-	 git merge c &&
-	 git checkout -b cb c -- &&
-	 git merge b &&
+	 git checkout -b xbc xb -- &&
+	 git merge xc &&
+	 git checkout -b xcb xc -- &&
+	 git merge xb &&
 	 git checkout master)
 '
 
 # no commits in bc descend from cb
 test_expect_success 'criss-cross: rev-list --ancestry-path cb..bc' '
 	(cd criss-cross &&
-	 git rev-list --ancestry-path cb..bc > actual &&
+	 git rev-list --ancestry-path xcb..xbc > actual &&
 	 test -z "$(cat actual)")
 '
 
 # no commits in repository descend from cb
 test_expect_success 'criss-cross: rev-list --ancestry-path --all ^cb' '
 	(cd criss-cross &&
-	 git rev-list --ancestry-path --all ^cb > actual &&
+	 git rev-list --ancestry-path --all ^xcb > actual &&
 	 test -z "$(cat actual)")
 '
 
-- 
1.7.7.rc1.366.ge210a6
Next: Brad King
Message 1 of 5 in “t6019: avoid refname collision on case-insensitive systems”
  1. t6019: avoid refname collision on case-insensitive systemsThomas Rast, Sep 15, 2011
  2. Brad KingSep 15, 2011
  3. Junio C HamanoSep 15, 2011
  4. Jeff KingSep 15, 2011
  5. Junio C HamanoSep 15, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.