Re: [RFC/PATCH v2] doc branch: provide examples for listing remote tracking branches
- From
Philip Oakley <philipoakley@iee.org>
- Date
- Jun 14, 2019, 21:00 UTC
- Message-ID
- <024373d9-e032-1af8-ba26-439ad5620bf5@iee.org>
- In-Reply-To
- <xmqqtvcxmig3.fsf@gitster-ct.c.googlers.com>
Hi Junio,
On 10/06/2019 18:57, Junio C Hamano wrote:
Show 36 quoted lines
> Philip Oakley <philipoakley@iee.org> writes: > >> The availability of these pattern selections is not obvious from >> the man pages, as per mail thread <87lfz3vcbt.fsf@evledraar.gmail.com>. >> >> Provide examples. >> >> Re-order the `git branch` synopsis to emphasise the `--list <pattern>` >> pairing. Also expand and reposition the `all/remotes` options. >> >> Split the over-long description into three parts so that the <pattern> >> description can be seen. >> >> Clarify that the `all/remotes` options require the --list if patterns >> are to be used. >> >> Add examples of listing remote tracking branches that match a pattern, >> including `git for-each-ref` which has more options. >> >> Improve the -a/-r warning message. The message confused this author >> as the combined -a and -r options had not been given, though a pattern >> had. Specifically guide the user that maybe they needed the --list >> option to enable a remote branch pattern selection. >> >> Signed-off-by: Philip Oakley <philipoakley@iee.org> >> --- >> >> in response to >> <2ea35ad4-4b33-0ece-4de4-b2e92a100d9a@iee.org> >> thread: https://public-inbox.org/git/?q=%3CCACsJy8CwY8gzeWa9kNRX3ecez1JGiQiaOknbAoU7S%2BhiXBoUGQ%40mail.gmail.com%3E >> >> to: Git Mailing List <git@vger.kernel.org> >> cc: Duy Nguyen <pclouds@gmail.com> >> cc: Ævar Arnfjörð Bjarmason <avarab@gmail.com> >> cc: Junio C Hamano <gitster@pobox.com> > This looks reasonable to me---is it ready to go even with its RFC prefix?
Yes; the RFC was only in regard of the die() message change as it touches real code;-)
Following the post, Stolee's coverage report, it was noted that the die() wasn't actually tested, so I sent a quick follow-up of a potential test https://public-inbox.org/git/f28dd5b1-fda8-cf51-5582-067a7d2c2472@iee.org/ which is a proper RFC...
I did not attempt to see if any other dies()'s were untested, just copied one that was..
Philip
(currently travelling)