Re: [PATCH 1/1] contrib/buildsystems: fix Visual Studio Debug configuration

From: Philip Oakley <philipoakley@iee.email>
Date: Dec 1, 2019, 23:41 UTC
Message-ID: <021de37a-5317-6c96-eae3-d0228a193d8b@iee.email>
In-Reply-To: <0b2124b5-6d40-08bb-6cc5-a8cef2b7a9b1@syntevo.com>

On 28/11/2019 10:07, Alexandr Miloslavskiy wrote:

Show 10 quoted lines

> On 28.11.2019 1:34, Philip Oakley wrote:
>
>> Hmm, 45 minutes of cloning and rebuild, but finally it compiled clean 
>> (both Release and Debug)
>
> I understand that the issue is resolved now.
>
> Probably your old repo was missing the libraries for whatever reason 
> (like antivirus deleting them, etc), but build script thought that 
> dependencies are properly built, so didn't attempt to rebuild them.

I was searching for how Visual Studio managed to decide if the vcpkg needed installing. I think I've found it in 384a61bc6a ("contrib/buildsystems: add a backend for modern Visual Studio versions", 2019-07-29) where dscho says:

    we initialize the `vcpkg` conditionally, in the `libgit` project's
    `PreBuildEvent`. To allow for parallel building of the projects, we
    therefore put `libgit` at the bottom of the project hierarchy.

What's not clear is if the conditional pre-build can have an if-else option so that we can have an 'update' check if already installed. Adding the vcpkg update to the vcpkg_install.bat didn't work :-(

Philip

PS. the https://github.com/CoatiSoftware/Sourcetrail visualiser is looking nice.