git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] quote: use isalnum() to check for alphanumeric characters

From
René Scharfe <l.s.r@web.de>
Date
Feb 22, 2020, 18:51 UTC
Message-ID
<0157c714-2d9b-7896-f5dc-232d82a46625@web.de>

isalnum(c) is equivalent to isalpha(c) || isdigit(c), so use the former instead. The result is shorter, simpler and slightly more efficient.

Signed-off-by: René Scharfe <l.s.r@web.de>
---
 quote.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/quote.c b/quote.c
index 24a58ba454..bcc0dbc50d 100644
--- a/quote.c
+++ b/quote.c
@@ -55,7 +55,7 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
 	}

 	for (p = src; *p; p++) {
-		if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) {
+		if (!isalnum(*p) && !strchr(ok_punct, *p)) {
 			sq_quote_buf(dst, src);
 			return;
 		}
--
2.25.1
Next: Martin Ågren
Message 1 of 2 in “quote: use isalnum() to check for alphanumeric characters”
  1. quote: use isalnum() to check for alphanumeric charactersRené Scharfe, Feb 22, 2020
  2. Martin ÅgrenFeb 23, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.