RE: [Breakage] t0410 - subtests report unable to remove non-existent file.

From: Randall S. Becker <rsbecker@nexbridge.com>
Date: Mar 4, 2020, 22:13 UTC
Message-ID: <014d01d5f272$215c0550$64140ff0$@nexbridge.com>

On February 28, 2020 5:33 PM, I wrote:

Show 5 quoted lines

> To: 'git@vger.kernel.org' <git@vger.kernel.org>
> Subject: [Breakage] t0410 - subtests report unable to remove non-existent
> file.
> 
> Starting at t0410, subtest 5 (missing ref object, but promised, passes

fsck), on

Show 15 quoted lines

> the NonStop L-series platform, we are seeing errors like the following:
> 
> not ok 5 - missing ref object, but promised, passes fsck #
> #               rm -rf repo &&
> #               test_create_repo repo &&
> #               test_commit -C repo my_commit &&
> #
> #               A=$(git -C repo commit-tree -m a HEAD^{tree}) &&
> #
> #               # Reference $A only from ref
> #               git -C repo branch my_branch "$A" &&
> #               promise_and_delete "$A" &&
> #
> #               git -C repo config core.repositoryformatversion 1 &&
> #               git -C repo config extensions.partialclone "arbitrary

string" &&

Show 19 quoted lines

> #               git -C repo fsck
> #
> 
> With verbose output as follows:
> 
> Initialized empty Git repository in /home/ituglib/randall/git/t/trash
> directory.t0410-partial-clone/repo/.git/
> [master (root-commit) 9df77b9] my_commit
>  Author: A U Thor <author@example.com>
>  1 file changed, 1 insertion(+)
>  create mode 100644 my_commit.t
> Enumerating objects: 1, done.
> Counting objects: 100% (1/1), done.
> Writing objects: 100% (1/1), done.
> Total 1 (delta 0), reused 0 (delta 0)
> a391e3e0447189aa0050c8f206462a1b0530a34a
> rm: cannot remove
> 'repo/.git/objects/a3/91e3e0447189aa0050c8f206462a1b0530a34a': No
> such file or directory

This appears to be an incompatibility in the script between running with /bin/sh (ksh on the platform) and bash. When we use make SHELL=/usr/coreutils/bin/bash (where our bash is located), this test passes. We will use this construct going forward, assuming we don't encounter something weird. So far, only t0301 and t1091 are failing. These are new failures. I will investigate and report on these separately.

Regards, Randall