Re: Git Test Coverage Report (Nov 25)

From: Phillip Wood <phillip.wood123@gmail.com>
Date: Nov 28, 2019, 11:06 UTC
Message-ID: <014924b0-f203-d3a3-f974-b1164511dbc6@gmail.com>
In-Reply-To: <nycvar.QRO.7.76.6.1911262116100.31080@tvgsbejvaqbjf.bet>

On 26/11/2019 20:46, Johannes Schindelin wrote:

> Hi Stolee,
> 
> thank you for keeping doing these reports.
>

Yes thanks Stolee, these reports are really useful

Show 18 quoted lines

> On Mon, 25 Nov 2019, Derrick Stolee wrote:
> 
>> Here is today's test coverage report.
>>
>> Sorry for the delay, but I had some issues working out the new
>> "ignored lines" logic. Now there are a few phrases that are
>> ignored automatically, including "BUG(" or "die(".
>>
>> [...]
>> Johannes Schindelin	116a408b commit: give correct advice for empty commit during a rebase
>> builtin/commit.c
>> 116a408b 478) else if (whence == FROM_CHERRY_PICK) {
>> 116a408b 479) if (rebase_in_progress && !sequencer_in_use)
>> 116a408b 1186) else if (whence == FROM_CHERRY_PICK) {
>> 116a408b 1187) if (rebase_in_progress && !sequencer_in_use)
> 
> My understanding is that Phillip is working on a replacement for this
> patch, so I'll leave this as-is for now.

I am, I'll add some tests to address this

Best Wishes

Phillip