RE: Git 2.54.0-rc1, subtests of t5310, t5326, t5327
- From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
- Date
- Apr 8, 2026, 18:36 UTC
- Message-ID
- <014801dcc786$9ff5bf60$dfe13e20$@nexbridge.com>
- In-Reply-To
- <20260408173949.GB2850002@coredump.intra.peff.net>
On April 8, 2026 1:40 PM, Jeff King wrote:
Show 12 quoted lines
>On Wed, Apr 08, 2026 at 12:25:47PM -0400, rsbecker@nexbridge.com wrote: > >> This is also impacting t5608 and t7700. Anywhere where writev() is >> used, seemingly. We went through MAX_IO_SIZE issues years ago, instead >> of using ssize_t as a basis of how big communication is. I think >> writev() is not valid. It worked on Lunix, but had issues elsewhere. >> This broke the compat layer. > >I wondered briefly if the problem could be that we're violating MAX_IO_SIZE here, >as our use of writev() does not respect it at all. But the only spot that uses it is >feeding pkt-line packets, which max out at 64k. So unless your MAX_IO_SIZE is >smaller than that, I doubt that is the problem.
SSIZE_MAX on platform is 53248, so yes. We expected git-compat-util.h at line 696 to be honoured.