[PATCH 5/5] streaming: simplify attaching a filter
- From
John Keeping <john@keeping.me.uk>
- Date
- Feb 16, 2014, 16:06 UTC
- Message-ID
- <0120f99a7cccc118782cda63f478d7d3f528ee3f.1392565571.git.john@keeping.me.uk>
- In-Reply-To
- <cover.1392565571.git.john@keeping.me.uk>
We are guaranteed that 'nst' is non-null because it is allocated with xmalloc(), and in fact we rely on this three lines later by unconditionally dereferencing it.
Signed-off-by: John Keeping <john@keeping.me.uk> --- streaming.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/streaming.c b/streaming.c index d7c9f32..8a7135d 100644 --- a/streaming.c +++ b/streaming.c @@ -151,10 +151,7 @@ struct git_istream *open_istream(const unsigned char *sha1, } if (filter) { /* Add "&& !is_null_stream_filter(filter)" for performance */ - struct git_istream *nst = attach_stream_filter(st, filter); - if (!nst) - close_istream(st); - st = nst; + st = attach_stream_filter(st, filter); } *size = st->size;
-- 1.9.rc0.187.g6292fff