RE: [BUG] Non-portable Construct Introduced in diagnose.c (dirent) at v2.38.0-rc0

From: rsbecker@nexbridge.com <rsbecker@nexbridge.com>
Date: Sep 16, 2022, 23:14 UTC
Message-ID: <011101d8ca22$04b68940$0e239bc0$@nexbridge.com>
In-Reply-To: <5d02d3b8-dc79-a2d8-f5e1-129d2228ff23@github.com>

On September 16, 2022 7:11 PM, Victoria Dye wrote:

Show 15 quoted lines

>rsbecker@nexbridge.com wrote:
>> The dirent d_type field is not available on every system. This was
>> introduced at 2.38.0-rc0 in diagnose.c
>>
>> diagnose.c, line 79: error(1565): struct "dirent" has no field "d_type"
>>
>>   		    e->d_type == DT_DIR && strlen(e->d_name) == 2 &&
>>
>> (3 more issues in diagnose exist of this form).
>>
>> The code should use the  NO_D_TYPE_IN_DIRENT knob to detect whether
>> this is an existing field as defined in cache.h.
>
>Apologies for missing that, I'll try to send a patch fixing it either later today or
>sometime Monday.

Thanks. If you need it tested in advance "in the wild", please let me know.

Regards, Randall