RE: [BUG] git 2.44.0-rc0 t0080.1 Breaks on NonStop x86 and ia64
- From
rsbecker@nexbridge.com <rsbecker@nexbridge.com>
- Date
- Feb 12, 2024, 19:26 UTC
- Message-ID
- <010d01da5de9$6c40a530$44c1ef90$@nexbridge.com>
- In-Reply-To
- <xmqqil2t5wwk.fsf@gitster.g>
On Monday, February 12, 2024 2:02 PM, Junio C Hamano wrote:
Show 22 quoted lines
><rsbecker@nexbridge.com> writes: > >> On Monday, February 12, 2024 11:43 AM, Junio C Hamano wrote: >>><rsbecker@nexbridge.com> writes: >>> >>>>>This looks like a good plan. >>>> >>>> This might be trivial, but I cannot tell. The #ifndef should be >>>> changed >> as >>>> follows: >>> >>>https://lore.kernel.org/git/xmqqttmf9y46.fsf@gitster.g/ >> >> I applied this fix but there is no improvement in the result from the >> last report. actual just has two lines. expect looks reasonable. I >> still had to modify the #ifndef. >> >> I have tried cherry-picking the change (no effect), building on >> master, next... am lost. > >We seem to be looking at something totally different. The later patch in
question
>(not the "looks like a good plan" outline) does not have any #ifndef and
applies the
>make_relative() logic everywhere. > >I would suspect that cherry-picking f6628636 (unit-tests: do show relative
file
>paths on non-Windows, too, 2024-02-11) would be the simplest.
Would you mind pushing that commit to github, please? It is not in the current history.