git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] completion (zsh): fix misleading install location

From
DSDurant Schoon <durant.schoon@gmail.com>
Date
Jun 6, 2019, 21:38 UTC
Message-ID
<0102016b2ebafc26-1bd39076-62e4-4b7e-9309-b08cc072fbdf-000000@eu-west-1.amazonses.com>

When the code comment in the zsh completion suggests that this file should be copied to `~/.zsh`, many users might be misled to believe that this refers to a file location. But it refers to a directory, and won't work when it is a file.

Let's just add a slash, to make it abundantly clear that this must be a directory.

(thank you to Johannes Schindelin for the suggested wording and title)
Signed-off-by: B. Durant Schoon durant.schoon@gmail.com
---
 contrib/completion/git-completion.zsh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/contrib/completion/git-completion.zsh b/contrib/completion/git-completion.zsh
index 886bf95d1f594..0e63004e2613e 100644
--- a/contrib/completion/git-completion.zsh
+++ b/contrib/completion/git-completion.zsh
@@ -11,8 +11,8 @@
 #
 #  zstyle ':completion:*:*:git:*' script ~/.git-completion.zsh
 #
-# The recommended way to install this script is to copy to '~/.zsh/_git', and
-# then add the following to your ~/.zshrc file:
+# The recommended way to install this script is to copy to '~/.zsh/_git/',
+# and then add the following to your ~/.zshrc file:
 #
 #  fpath=(~/.zsh $fpath)
 

--
https://github.com/git/git/pull/609
Next: Denton Liu
Message 1 of 5 in “completion (zsh): fix misleading install location”
  1. completion (zsh): fix misleading install locationDurant Schoon, Jun 6, 2019
  2. Denton LiuJun 6, 2019
  3. Felipe ContrerasJun 6, 2019
  4. completion (zsh): fix misleading install locationDurant Schoon, Sep 24, 2019
  5. Maxim BelskyOct 1, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.