git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH RFC v2 4/4] ref-filter: add deltabase formatting option

From
Olga Telezhnaya <olyatelezhnaya@gmail.com>
Date
May 18, 2018, 08:19 UTC
Message-ID
<010201637254ca34-c7632c6b-dcab-439f-a2fb-cf270a881534-000000@eu-west-1.amazonses.com>
In-Reply-To
<010201637254c969-a346030e-0b75-41ad-8ef3-2ac7e04ba4fb-000000@eu-west-1.amazonses.com>

Add %(deltabase) support. It is still not working for deref: I am thinking how to support it in a more elegant way.

Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com>
---
 ref-filter.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)
diff --git a/ref-filter.c b/ref-filter.c
index c00de58455301..989ccdb356a32 100644
--- a/ref-filter.c
+++ b/ref-filter.c
@@ -276,6 +276,14 @@ static int objecttype_atom_parser(const struct ref_format *format, struct used_a
 	return 0;
 }
 
+static int deltabase_atom_parser(const struct ref_format *format, struct used_atom *atom,
+				  const char *arg, struct strbuf *unused_err)
+{
+	oi_data.use_data = 1;
+	oi_data.info.delta_base_sha1 = oi_data.delta_base_oid.hash;
+	return 0;
+}
+
 static int objectsize_atom_parser(const struct ref_format *format, struct used_atom *atom,
 				  const char *arg, struct strbuf *err)
 {
@@ -409,6 +417,7 @@ static struct {
 	{ "objecttype", FIELD_STR, objecttype_atom_parser },
 	{ "objectsize", FIELD_ULONG, objectsize_atom_parser },
 	{ "objectname", FIELD_STR, objectname_atom_parser },
+	{ "deltabase", FIELD_STR, deltabase_atom_parser },
 	{ "tree" },
 	{ "parent" },
 	{ "numparent", FIELD_ULONG },
@@ -1572,6 +1581,9 @@ static int populate_value(struct ref_array_item *ref, struct strbuf *err)
 				v->s = xstrfmt("%lu", oi_data.disk_size);
 			}
 			continue;
+		} else if (!deref && !strcmp(name, "deltabase") && oi_data.use_data) {
+			v->s = xstrdup(oid_to_hex(&oi_data.delta_base_oid));
+			continue;
 		} else if (!strcmp(name, "HEAD")) {
 			if (atom->u.head && !strcmp(ref->refname, atom->u.head))
 				v->s = "*";

--
https://github.com/git/git/pull/493
Previous: Olga TelezhnayaNext: Olga Telezhnaya
Message 2 of 4 in “ref-filter: start using oid_object_info”
  1. 1/4 ref-filter: start using oid_object_infoOlga Telezhnaya, May 18, 2018
  2. 4/4 ref-filter: add deltabase formatting optionOlga Telezhnaya, May 18, 2018
  3. 3/4 ref-filter: add tests for objectsize:diskOlga Telezhnaya, May 18, 2018
  4. 2/4 ref-filter: add objectsize:disk formatting optionOlga Telezhnaya, May 18, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.