[PATCH RFC 21/24] ref-filter: work with objectsize:disk
- From
Olga Telezhnaya <olyatelezhnaya@gmail.com>
- Date
- Jan 26, 2018, 19:43 UTC
- Message-ID
- <0102016133ff3b53-0d7be81e-3350-4d32-bbb1-b108a1b27c41-000000@eu-west-1.amazonses.com>
- In-Reply-To
- <0102016133ff3a86-44d354ec-13c6-4c38-bc75-1ba4422db5a7-000000@eu-west-1.amazonses.com>
Make a temporary solution for commands that could use objectsize:disk atom. It's better to fill it with value or give an error if there is no value for this atom, but as a first solution we do dothing. It means that if objectsize:disk is used, we put an empty string there.
Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com> Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored by: Jeff King <peff@peff.net> --- ref-filter.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c index 2cac394e93f52..bf49ed21eaac5 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -826,8 +826,10 @@ static void grab_common_values(struct atom_value *val, int deref, struct object v->value = sz; v->s = xstrfmt("%lu", sz); } else if (!strcmp(name, "objectsize:disk")) { - v->value = cat_file_info.disk_size; - v->s = xstrfmt("%"PRIuMAX, (uintmax_t)v->value); + if (is_cat) { + v->value = cat_file_info.disk_size; + v->s = xstrfmt("%"PRIuMAX, (uintmax_t)v->value); + } } else if (deref) grab_objectname(name, obj->oid.hash, v, &used_atom[i]); } -- https://github.com/git/git/pull/452