git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] use filetest pragma to work with ACL

From
GCGuillaume Castagnino <casta+github@xwing.info>
Date
Oct 18, 2017, 19:55 UTC
Message-ID
<0102015f310e24b9-b96378f3-a029-4110-80dd-e454522e2cb7-000000@eu-west-1.amazonses.com>
From: Guillaume Castagnino <casta@xwing.info>
as stated in comment in https://github.com/git/git/commit/46a13857fc036b54ac2ddd0a218e5cc171aa7bd9#diff-00703a794a540acf45e225abd6aeda3b the referenced commit is broken when using ACL and not basic UNIX rights.
this commit handle ACL too
---
 gitweb/gitweb.perl | 1 +
 1 file changed, 1 insertion(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 9208f42ed1753..0ee7f304ce2b1 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3072,6 +3072,7 @@ sub git_get_projects_list {
 				# only directories can be git repositories
 				return unless (-d $_);
 				# need search permission
+				use filetest 'access';
 				return unless (-x $_);
 				# don't traverse too deep (Find is super slow on os x)
 				# $project_maxdepth excludes depth of $projectroot

--
https://github.com/git/git/pull/416
Next: Stefan Beller
Message 1 of 6 in “use filetest pragma to work with ACL”
  1. use filetest pragma to work with ACLGuillaume Castagnino, Oct 18, 2017
  2. Stefan BellerOct 18, 2017
  3. Jeff KingOct 18, 2017
  4. Guillaume CastagninoOct 19, 2017
  5. Jeff KingOct 19, 2017
  6. Junio C HamanoOct 24, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.