git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] sha1_file: remove an used fd variable

From
Sebastian Schuberth <sschuberth@gmail.com>
Date
Apr 16, 2017, 19:04 UTC
Message-ID
<0102015b7826824a-7bacaa78-5158-4d33-9615-e1a5bffea7a2-000000@eu-west-1.amazonses.com>
Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
---
 sha1_file.c | 3 ---
 1 file changed, 3 deletions(-)
diff --git a/sha1_file.c b/sha1_file.c
index 7106389..9ecf71f 100644
--- a/sha1_file.c
+++ b/sha1_file.c
@@ -3970,7 +3970,6 @@ int read_loose_object(const char *path,
 		      void **contents)
 {
 	int ret = -1;
-	int fd = -1;
 	void *map = NULL;
 	unsigned long mapsize;
 	git_zstream stream;
@@ -4020,7 +4019,5 @@ int read_loose_object(const char *path,
 out:
 	if (map)
 		munmap(map, mapsize);
-	if (fd >= 0)
-		close(fd);
 	return ret;
 }

--
https://github.com/git/git/pull/344
Next: Jeff King
Message 1 of 2 in “sha1_file: remove an used fd variable”
  1. sha1_file: remove an used fd variableSebastian Schuberth, Apr 16, 2017
  2. Jeff KingApr 17, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.