git/list[1] front-page[2] threads[3] people[4] search[5] about
 

RE: [Suggestion] Documentation: quick-install-man not propagating DESTDIR

From
Randall S. Becker <rsbecker@nexbridge.com>
Date
Sep 2, 2020, 19:52 UTC
Message-ID
<00c101d68162$a598c900$f0ca5b00$@nexbridge.com>
In-Reply-To
<xmqqft80arpy.fsf@gitster.c.googlers.com>
On September 2, 2020 3:45 PM, Junio C Hamano wrote:
Show 25 quoted lines
> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
> 
> > The make quick-install-man rule is not propagating DESTDIR when GNU
> > Make
> > 4.2.1 is used.
> 
> I wonder, instead of having to change all "$(MAKE) -C elsewhere", we can
> add DESTDIR to the list of variables that are exported.
> 
> ... goes and looks ...
> 
> Hmph, DESTDIR is exported together with DIFF, TAR, INSTALL and
> SHELL_PATH.  We do rely on SHELL_PATH to be exported correctly to
> t/Makefile for "make test" to work, so it is puzzling.
> 
> It is doubly puzzling that we use $(INSTALL) in Documentation/Makefile on
> the same line as $(DESTDIR) is used, and apparently you are not reporting
> problem on that one.
> 
> > It seems like a bit of a nit to report this, but I discovered that the
> > installation is not putting the manuals in the same place as git. It’s
> > a pretty simple fix. I can put a patch together if desired.
> 
> I do not think we want that patch.  Instead I think we'd want a patch that
> uses the same trick as what makes INSTALL work.
I'll look into that approach. Thanks for the direction.

Regards, Randall

Previous: Junio C Hamano
Message 3 of 3 in “[Suggestion] Documentation: quick-install-man not propagating DESTDIR”
  1. Randall S. BeckerSep 1, 2020
  2. Junio C HamanoSep 2, 2020
  3. Randall S. BeckerSep 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.