git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] mingw: use OpenSSL's SHA-1 routines

From
Johannes Sixt <j6t@kdbg.org>
Date
Feb 16, 2017, 18:12 UTC
Message-ID
<0080edd6-a515-2fe9-6266-b6f6bbedfdde@kdbg.org>
In-Reply-To
<alpine.DEB.2.20.1702131815351.3496@virtualbox>
Am 13.02.2017 um 18:16 schrieb Johannes Schindelin:
Show 26 quoted lines
> On Sat, 11 Feb 2017, Johannes Sixt wrote:
>> Am 10.02.2017 um 00:41 schrieb Junio C Hamano:
>>> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
>>>
>>>> From: Jeff Hostetler <jeffhost@microsoft.com>
>>>>
>>>> Use OpenSSL's SHA-1 routines rather than builtin block-sha1
>>>> routines.  This improves performance on SHA1 operations on Intel
>>>> processors.
>>>> ...
>>>>
>>>> Signed-off-by: Jeff Hostetler <jeffhost@microsoft.com>
>>>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>>>> ---
>>>
>>> Nice.  Will queue as jh/mingw-openssl-sha1 topic; it is a bit too
>>> late for today's integration cycle to be merged to 'next', but let's
>>> have this by the end of the week in 'master'.
>>
>> Please don't rush this through. I didn't have a chance to cross-check the
>> patch; it will have to wait for Monday. I would like to address Peff's
>> concerns about additional runtime dependencies.
>
> I never meant this to be fast-tracked into git.git. We have all the time
> in our lives to get this in, as Git for Windows already carries this patch
> for a while, and shall continue to do so.

I've been working with this patch for the past few days, and I did not notice any disadvantage during interactive work even though there is a new dependency on libcrypto.dll.

Here are some unscientific numbers collected during test suite runs:
bash -c "time make -j4 -k test"
with this patch:

real 34m47.242s user 9m55.827s sys 25m20.483s

without this patch:

real 34m2.330s user 9m56.556s sys 25m5.520s

It looks like BLK_SHA1 has some advantage, but I would not count on these figures too much. (I certainly did not sit idly in front of the workstation during these tests, for example. That may have skewed the numbers somewhat.) (And, no, I'm not going to measure best-of-five timings, not even best-of-two. ;)

In summary: Interactive response times do not decline noticably. I do not object the patch.

-- Hannes
Previous: Johannes SchindelinNext: Jeff King
Message 6 of 18 in “mingw: use OpenSSL's SHA-1 routines”
  1. mingw: use OpenSSL's SHA-1 routinesJohannes Schindelin, Feb 9, 2017
  2. Junio C HamanoFeb 9, 2017
  3. Johannes SixtFeb 11, 2017
  4. Junio C HamanoFeb 11, 2017
  5. Johannes SchindelinFeb 13, 2017
  6. Johannes SixtFeb 16, 2017
  7. Jeff KingFeb 10, 2017
  8. Johannes SchindelinFeb 10, 2017
  9. Jeff KingFeb 10, 2017
  10. Johannes SixtFeb 13, 2017
  11. Junio C HamanoFeb 13, 2017
  12. Johannes SixtFeb 13, 2017
  13. Johannes SchindelinFeb 13, 2017
  14. Johannes SixtFeb 14, 2017
  15. Junio C HamanoFeb 24, 2017
  16. Johannes SixtMar 2, 2017
  17. Junio C HamanoMar 2, 2017
  18. Linus TorvaldsFeb 25, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.