Re: [PATCH] mktree: learn about promised objects

From: Derrick Stolee <derrickstolee@github.com>
Date: Jun 14, 2022, 14:14 UTC
Message-ID: <0067c46a-7bfd-db9c-5156-16f032814464@github.com>
In-Reply-To: <77035a0f-c42e-5cb3-f422-03fe81093adb@roku.com>

On 6/14/2022 9:36 AM, Richard Oliver wrote:

Show 6 quoted lines

> Do not use oid_object_info() to determine object type in mktree_line()
> as this can cause promised objects to be dynamically faulted-in one at a
> time which has poor performance. Instead, use a combination of
> oid_object_info_extended() (with OBJECT_INFO_SKIP_FETCH_OBJECT option),
> and the newly introduced promisor_object_type() to determine object type
> before defaulting to fetch from remote.

Have you run some performance tests on this? It seems like this will scan all packed objects, which is probably much slower than just asking the remote for the object in most cases.

Thanks, -Stolee