RE: [PATCH v4 2/4] config.mak.uname: support for modern HPE NonStop config.

From

Rrandall.s.becker@rogers.com <randall.s.becker@rogers.com>

Date

Jan 3, 2019, 19:58 UTC

Message-ID

<006501d4a39e$b99fe0d0$2cdfa270$@rogers.com>

In-Reply-To

<xmqqimz5h6et.fsf@gitster-ct.c.googlers.com>

On January 3, 2019 14:45, Junio C Hamano wrote:

> To: randall.s.becker@rogers.com
> Cc: git@vger.kernel.org; Randall S. Becker <rsbecker@nexbridge.com>
> Subject: Re: [PATCH v4 2/4] config.mak.uname: support for modern HPE
> NonStop config.
> 
> randall.s.becker@rogers.com writes:
> 
> > @@ -470,8 +489,13 @@ ifeq ($(uname_S),NONSTOP_KERNEL)
> >  	NO_MKDTEMP = YesPlease
> >  	# Currently libiconv-1.9.1.
> >  	OLD_ICONV = UnfortunatelyYes
> > -	NO_REGEX = YesPlease
> > +	NO_REGEX=NeedsStartEnd
> >  	NO_PTHREADS = UnfortunatelyYes
> >
> >  	# Not detected (nor checked for) by './configure'.
> >  	# We don't have SA_RESTART on NonStop, unfortunalety.
> 
> The hunk header claims that the preimage has 8 lines while the postimage
> has 13 lines, adding 5 new lines in total.  But that is not what we can

see in

> the hunk.
> 
> It is unclear to me if the numbers on the hunk header are bogus, or the

patch

> text was truncated, so I cannot use these two patches with confidence.

The

> first hunk had the same issue, and 1/4 too.
> 
> I do not see v4 3/4 and v4 4/4, either.  It's not like you are the only

person

> who sends patches to the mailing list, and not having the patches as
> responses to a cover letter for proper threading makes it very hard to see
> which patches belong to the same series and if all the necessary patches

in a

> series have become available.
> Is it possible to arrange that to happen?
> 
> Thanks.