RE: [RFE] install-doc-quick.sh should accept a commit-ish

From

Randall S. Becker <rsbecker@nexbridge.com>

Date

Dec 6, 2017, 16:48 UTC

Message-ID

<004001d36eb2$10f8ef20$32eacd60$@nexbridge.com>

In-Reply-To

<xmqqtvx3hkst.fsf@gitster.mtv.corp.google.com>

On December 6, 2017 11:40 AM, Junio C Hamano wrote:

>"Randall S. Becker" <rsbecker@nexbridge.com> writes:
>> Having the git-manpages repo available is fantastic for platforms that 
>> cannot easily build documentation on demand, for example, when too 
>> many dependencies that do not build properly.
>> It would be really nice to have a version of install-doc-quick.sh to

either:

>> 1. Use whatever version is checked out in git-manpages; or
>> 2. Use the proper commit associated with the git commit being 
>> installed (0a8e923 for v2.6.0 , as an example); or
>> 3. Allow the commit to be passed through the Documentation Makefile on

demand so that any version of documentation can be installed.

>Do you mean something like this so that you can say "not the tip of the

master branch but this one?"

> Documentation/install-doc-quick.sh | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

>diff --git a/Documentation/install-doc-quick.sh

b/Documentation/install-doc-quick.sh

>index 327f69bcf5..83764f7537 100755
>--- a/Documentation/install-doc-quick.sh
>+++ b/Documentation/install-doc-quick.sh
>@@ -3,8 +3,9 @@

> repository=${1?repository}
> destdir=${2?destination}
>+head=${3+master}
>+GIT_DIR=

>-head=master GIT_DIR=
> for d in "$repository/.git" "$repository"
> do
> 	if GIT_DIR="$d" git rev-parse refs/heads/master >/dev/null 2>&1