RE: [Nit] Lots of enumerated type warnings

From: Randall S. Becker <rsbecker@nexbridge.com>
Date: Jan 22, 2018, 22:52 UTC
Message-ID: <001501d393d3$b82150d0$2863f270$@nexbridge.com>
In-Reply-To: <xmqqo9lljz3l.fsf@gitster.mtv.corp.google.com>

On January 22, 2018 5:41 PM, Junio C Hamano wrote:

Show 10 quoted lines

> "Randall S. Becker" <rsbecker@nexbridge.com> writes:
> 
> > I'm seeing an increase in the enumerated type warnings coming from my
> > use of the c99 compiler for compiling git over time (loads more for
> > 2.16.0 compared to 2.3.7 when I took it on).
> 
> What exactly do these "warnings" complain about?  Without knowing that,
> the remainder of your question cannot be answered.
> 
> Does it complain against enum FOO {A,B,C,} saying that the comma after C

is

> not kosher in older C standard, for example?

Here are a few examples, there are more:

auto_crlf = git_config_bool(var, value);
  		          ^
"/home/jenkins/.jenkins/workspace/Build_Git/config.c", line 1147:
warning(272): 
          enumerated type mixed with another type

type = sha1_object_info(s->oid.hash, &s->size);
  			     ^
"/home/jenkins/.jenkins/workspace/Build_Git/diff.c", line 3618:
warning(272): 
          enumerated type mixed with another type

options->color_moved = diff_color_moved_default;
  	                     ^
"/home/jenkins/.jenkins/workspace/Build_Git/diff.c", line 4108:
warning(272): 
          enumerated type mixed with another type

options->color_moved = 0;
  		                     ^
"/home/jenkins/.jenkins/workspace/Build_Git/diff.c", line 4218:
warning(272): 
          enumerated type mixed with another type