Re: [PATCH] gitk: new option to hide prefetch refs

From: Derrick Stolee <stolee@gmail.com>
Date: Aug 24, 2021, 13:49 UTC
Message-ID: <0004f758-759b-f523-fa3d-dd7759d6eec7@gmail.com>
In-Reply-To: <pull.1023.git.1629807526939.gitgitgadget@gmail.com>

On 8/24/2021 8:18 AM, Tal Kelrich via GitGitGadget wrote:

Show 6 quoted lines

> From: Tal Kelrich <hasturkun@gmail.com>
> 
> The maintenance 'prefetch' task creates refs that mirror remote refs,
> and in repositories with many branches this can clutter the commit list.
> 
> Add a new option to ignore any prefetch refs, enabled by default.

This seems like a sensible feature to add. Thank you for contributing!

>     It might have been better to allow gitk to read log.excludeDecoration
>     (or a gitk specific configured pattern) and use that to ignore refs, but
>     this was simpler for me to implement without knowing Tcl.

I agree, but I also don't know Tcl so can't comment to how hard that might be. I'm not sure how gitk operates and why it does not automatically benefit from log.excludeDecoration. Is it computing its own decoration? Is it using a different Git command that isn't integrated with log.excludeDecoration, but should be?

I also cannot review that this patch works as advertised. I just wanted to chime in with support for the idea.

Thanks, -Stolee