# [PATCH 0/5] gitweb: Fixes and improvements related to diffs 3 messages from 2007-09-21 to 2007-09-25. Participants: Jakub Narebski, Junio C Hamano. Thread: https://gitlist.dev/t/9965 ## Jakub Narebski, 2007-09-21 21:31 Subject: [PATCH 0/5] gitweb: Fixes and improvements related to diffs Message-ID: <8fe92b430709211431m7a93a11cp915988a57801edd6@mail.gmail.com> URL: https://gitlist.dev/e/8fe92b430709211431m7a93a11cp915988a57801edd6%40mail.gmail.com ``` This series of patches adds fixes, simplifications and improvements related to diff handling in gitweb ('commit', 'commitdiff' views). Becaus I didn't have access to Internet, this series is based on 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76). As I am sending it via GMail WWW interface, patches are send as attachements. I send this series now, even without good Internet access, because it contains two bugfixes, and one code fix. I'll try to resend it rebase on top of current master later... Shortlog: ========= Jakub Narebski (5): gitweb: Remove parse_from_to_diffinfo code from git_patchset_body gitweb: No difftree output for trivial merge gitweb: Fix and simplify "split patch" detection gitweb: Always set 'from_file' and 'to_file' in parse_difftree_raw_line gitweb: Add 'status_str' to parse_difftree_raw_line output Diffstat: ========= gitweb/gitweb.perl | 208 ++++++++++++++++++++-------------------------------- 1 files changed, 80 insertions(+), 128 deletions(-) -- Jakub Narebski Poland ``` ## Junio C Hamano, 2007-09-25 22:16 Subject: Re: [PATCH 0/5] gitweb: Fixes and improvements related to diffs Message-ID: <7vodfq4ch0.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vodfq4ch0.fsf%40gitster.siamese.dyndns.org In-Reply-To: <8fe92b430709211431m7a93a11cp915988a57801edd6@mail.gmail.com> ``` "Jakub Narebski" writes: > This series of patches adds fixes, simplifications and improvements > related to diff handling in gitweb ('commit', 'commitdiff' views). > > Becaus I didn't have access to Internet, this series is based > on 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76). > As I am sending it via GMail WWW interface, patches are send as > attachements. > > I send this series now, even without good Internet access, > because it contains two bugfixes, and one code fix. I'll try to > resend it rebase on top of current master later... I've parked the first two in 'master' and was hoping to roll them into 'maint'. I haven't taken a look at the other three as I was waiting for a resend. If you think some of them are bugfix material for 'maint', please mark them as such. Thanks. ``` ## Jakub Narebski, 2007-09-25 22:21 Subject: Re: [PATCH 0/5] gitweb: Fixes and improvements related to diffs Message-ID: <8fe92b430709251521j2b596016l186bdbb08c6cf816@mail.gmail.com> URL: https://gitlist.dev/e/8fe92b430709251521j2b596016l186bdbb08c6cf816%40mail.gmail.com In-Reply-To: <7vodfq4ch0.fsf@gitster.siamese.dyndns.org> ``` On 9/26/07, Junio C Hamano wrote: > "Jakub Narebski" writes: > > > This series of patches adds fixes, simplifications and improvements > > related to diff handling in gitweb ('commit', 'commitdiff' views). > > > > Becaus I didn't have access to Internet, this series is based > > on 1e61b7640d09015213dbcae3564fa27ac6a8c151 (v1.5.3.1-1-g1e61b76). > > As I am sending it via GMail WWW interface, patches are send as > > attachements. > > > > I send this series now, even without good Internet access, > > because it contains two bugfixes, and one code fix. I'll try to > > resend it rebase on top of current master later... > > I've parked the first two in 'master' and was hoping to roll > them into 'maint'. I haven't taken a look at the other three as > I was waiting for a resend. If you think some of them are > bugfix material for 'maint', please mark them as such. Third fixes a rare bug when gitweb screwed up names of files in the patchset part of commitdiff view. This took place only (diagnosed by pasky) when there were different files which had the same preimage and the same postimage. -- Jakub Narebski ```