threads / patch / 9930

patchChange to simplified icon.

Subject: [EGIT PATCH] Change to simplified icon.

## tl;dr

9 messages between Sep 18, 2007 and Sep 25, 2007. Diffs are folded; open one to read it.

replies: 8people: 4as markdown or json

Ben Konrath· Sep 18, 2007, 22:24 UTC · lore
Hi Robin,

Here's a patch that changes the icon to something that is a little more aesthetically pleasing than the one I iniitially submitted. Feel free to use the one you like best.

Cheers, Ben
Signed-off-by: Ben Konrath <bkonrath@redhat.com>
---
 org.spearce.egit/egit.png |  Bin 305 -> 226 bytes
 1 files changed, 0 insertions(+), 0 deletions(-)
Show changes to org.spearce.egit/egit.png +0 −0
diff --git a/org.spearce.egit/egit.png b/org.spearce.egit/egit.png
index 6e231c2c78068d313500afd0192962de8c8028d5..6782d4ab9b757aaa2c3d5edad42215ea02456836 100644
GIT binary patch
delta 128
zc$@)%0Du3n0^$LXK?o5MJ0{fucRrCxENxgxL_t(Y$L*B44FDhv17pNqjD{GE$xJ~P
zx*(py?zrZRNB~JYnPi6}fdmqmWq0m?BZUm`dpCgoqL=^;XxQg39(gUo$^d^orn8sp
i65v`i2_%r<6Ttw60WCp3d$>IS0000<MNUMnLSTZ2z%jJ|

delta 208
zc$@*y05AXI0kHy*K?n>MDJ}#O78sF9EPtm-L_t(Y$L&;G4!|G?6SI5mXvU-MWZege
zOB9Ki`S{Q;t(bz85&$=Hc{g|sC%C#_QY79WU<g4YYd?XW_(#bqO3c~g4CgB`xQyg0
zFV@9K?UxZyrk{c7I9H}(nSaW(v2QkAiA`2oS2kIRM*uZ?QR7&d2dySw^A{aA-95;z
zAIc?o10DFh3XY082`G|iI97Z`lTEg&;HzcId6nL2#m}H^LGS`$*mx<?D@u<50000<
KMNUMnLSTZEmRRfn

-- 
1.5.2.4
Robin Rosenberg· Sep 19, 2007, 18:19 UTC · re: Ben Konrath · lore

Re: [EGIT PATCH] Change to simplified icon.

onsdag 19 september 2007 skrev Ben Konrath:
Show 5 quoted lines
> Hi Robin,
> 
> Here's a patch that changes the icon to something that is a little more
> aesthetically pleasing than the one I iniitially submitted. Feel free to
> use the one you like best.

The icon looks very similar to the one in GitWeb. The simplified is, without, making a bitwise compare, is seems identical to the Git icon. Is that appropriate? What do the author of that icon, and other Git developers, think?

The plugin. after all, does steal ideas and repository format from Git, but is in fact a completely separate implementation. 

I'll leave this one in my patch tree for now. The Egit icon contest is stil open to all.
-- robin
Robin Rosenberg· Sep 19, 2007, 20:57 UTC · re: Robin Rosenberg · lore

Re: [EGIT PATCH] Change to simplified icon.

onsdag 19 september 2007 skrev Robin Rosenberg:
> I'll leave this one in my patch tree for now. The Egit icon contest is stil 
open to all.

Here's another icon. The cup inspired the drug used to code the plugin. The +/-'s from the git logo, the blue color to look better with the other icons in Eclipse's about box and the rest comes form the fact that I cannot draw.

-- robin
Robin Rosenberg· Sep 19, 2007, 20:59 UTC · re: Robin Rosenberg · lore

Re: [EGIT PATCH] Change to simplified icon.

onsdag 19 september 2007 skrev Robin Rosenberg:
Show 8 quoted lines
> onsdag 19 september 2007 skrev Robin Rosenberg:
> > I'll leave this one in my patch tree for now. The Egit icon contest is stil 
> open to all.
> 
> Here's another icon. The cup inspired the drug used to code the plugin. The 
> +/-'s from the git logo, the blue color to look better with the other icons 
> in Eclipse's about box and the rest comes form the fact that I cannot draw.
> 
And the subject matter :)
-- robin
Shawn O. Pearce· Sep 24, 2007, 04:17 UTC · re: Robin Rosenberg · lore

Re: [EGIT PATCH] Change to simplified icon.

Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
Show 10 quoted lines
> onsdag 19 september 2007 skrev Robin Rosenberg:
> > onsdag 19 september 2007 skrev Robin Rosenberg:
> > > I'll leave this one in my patch tree for now. The Egit icon contest is stil 
> > open to all.
> > 
> > Here's another icon. The cup inspired the drug used to code the plugin. The 
> > +/-'s from the git logo, the blue color to look better with the other icons 
> > in Eclipse's about box and the rest comes form the fact that I cannot draw.
> > 
> And the subject matter :)

Very cute. I actually like it. Maybe I'll take a stab at creating a git-gui icon, because like you I also cannot draw. A feather and some pluses and minuses can't be that hard, can it? :)

Actually I just need to find a two year old. Any two year old with crayons can draw many times better than I ever could. However I think the difficult part is to get the two year old to draw the subject matter...

-- 
Shawn.
Johannes Schindelin· Sep 24, 2007, 10:26 UTC · re: Shawn O. Pearce · lore

Re: [EGIT PATCH] Change to simplified icon.

Hi,
On Mon, 24 Sep 2007, Shawn O. Pearce wrote:
Show 15 quoted lines
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > onsdag 19 september 2007 skrev Robin Rosenberg:
> > > onsdag 19 september 2007 skrev Robin Rosenberg:
> > > > I'll leave this one in my patch tree for now. The Egit icon contest is stil 
> > > open to all.
> > > 
> > > Here's another icon. The cup inspired the drug used to code the plugin. The 
> > > +/-'s from the git logo, the blue color to look better with the other icons 
> > > in Eclipse's about box and the rest comes form the fact that I cannot draw.
> > > 
> > And the subject matter :)
> 
> Very cute.  I actually like it.  Maybe I'll take a stab at creating
> a git-gui icon, because like you I also cannot draw.  A feather
> and some pluses and minuses can't be that hard, can it?  :)

You might want to look at http://git.or.cz/gitwiki/GitRelatedLogos (I especially like Henrik Nyh's, we use it in git-gui). Might be a good starting point.

Ciao, Dscho

Shawn O. Pearce· Sep 25, 2007, 01:16 UTC · re: Johannes Schindelin · lore

Re: [EGIT PATCH] Change to simplified icon.

Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 8 quoted lines
> On Mon, 24 Sep 2007, Shawn O. Pearce wrote:
> > 
> > [...] Maybe I'll take a stab at creating
> > a git-gui icon [...]
> 
> You might want to look at http://git.or.cz/gitwiki/GitRelatedLogos (I 
> especially like Henrik Nyh's, we use it in git-gui).  Might be a good 
> starting point.

What do you mean you "use it in git-gui" ? Have you patched git-gui to set the window icon to Henrik's? And not tried to contribute the patch upstream? Come on, show the GPL love... :-)

-- 
Shawn.
Johannes Schindelin· Sep 25, 2007, 09:53 UTC · re: Shawn O. Pearce · lore

Re: [EGIT PATCH] Change to simplified icon.

Hi,
On Mon, 24 Sep 2007, Shawn O. Pearce wrote:
Show 13 quoted lines
> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
> > On Mon, 24 Sep 2007, Shawn O. Pearce wrote:
> > > 
> > > [...] Maybe I'll take a stab at creating
> > > a git-gui icon [...]
> > 
> > You might want to look at http://git.or.cz/gitwiki/GitRelatedLogos (I 
> > especially like Henrik Nyh's, we use it in git-gui).  Might be a good 
> > starting point.
> 
> What do you mean you "use it in git-gui" ?  Have you patched git-gui to 
> set the window icon to Henrik's?  And not tried to contribute the patch 
> upstream?  Come on, show the GPL love... :-)
Oops.  I meant to say that we use it in msysGit.

Sorry, Dscho

Ben Konrath· Sep 19, 2007, 22:49 UTC · re: Robin Rosenberg · lore

Re: [EGIT PATCH] Change to simplified icon.

On Wed, 2007-09-19 at 20:19 +0200, Robin Rosenberg wrote:
Show 10 quoted lines
> onsdag 19 september 2007 skrev Ben Konrath:
> > Hi Robin,
> > 
> > Here's a patch that changes the icon to something that is a little more
> > aesthetically pleasing than the one I iniitially submitted. Feel free to
> > use the one you like best.
> 
> The icon looks very similar to the one in GitWeb. The simplified is, without,
> making a bitwise compare, is seems identical to the Git icon. Is that 
> appropriate? What do the author of that icon, and other Git developers, think?

I did actually make this icon with gimp but it is heavily inspired by the GitWeb icon. But I think this is moot because the icon you just made seems to be a better fit :)

Cheers, Ben
Show 7 quoted lines
> The plugin. after all, does steal ideas and repository format from Git,
> but is in fact a completely separate implementation. 
> 
> I'll leave this one in my patch tree for now. The Egit icon contest is stil open to all.
> 
> -- robin
>

← back to recent threads