# [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list 3 messages from 2007-09-05 to 2007-09-06. Participants: Dmitry V. Levin, Junio C Hamano. Thread: https://gitlist.dev/t/9789 ## Dmitry V. Levin, 2007-09-05 23:22 Subject: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Message-ID: <20070905232251.GC331@nomad.office.altlinux.org> URL: https://gitlist.dev/e/20070905232251.GC331%40nomad.office.altlinux.org ``` Some external projects (e.g. parsecvs) need cache-tree.h file. Signed-off-by: Dmitry V. Levin --- Makefile | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index d50e30b..2b04829 100644 --- a/Makefile +++ b/Makefile @@ -283,7 +283,7 @@ LIB_FILE=libgit.a XDIFF_LIB=xdiff/lib.a LIB_H = \ - archive.h blob.h cache.h commit.h csum-file.h delta.h grep.h \ + archive.h blob.h cache.h cache-tree.h commit.h csum-file.h delta.h grep.h \ diff.h object.h pack.h pkt-line.h quote.h refs.h list-objects.h sideband.h \ run-command.h strbuf.h tag.h tree.h git-compat-util.h revision.h \ tree-walk.h log-tree.h dir.h path-list.h unpack-trees.h builtin.h \ -- ldv ``` ## Junio C Hamano, 2007-09-06 00:16 Subject: Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Message-ID: <7vy7fkfy1c.fsf@gitster.siamese.dyndns.org> URL: https://gitlist.dev/e/7vy7fkfy1c.fsf%40gitster.siamese.dyndns.org In-Reply-To: <20070905232251.GC331@nomad.office.altlinux.org> ``` "Dmitry V. Levin" writes: > Some external projects (e.g. parsecvs) need cache-tree.h file. Your patch shows that our Makefile has been lacking a necessary dependency for a long time. LIB_H is not "public headers list", but more like "the headers everybody depends on", and the header file should have been on that list. Thanks. I am however not convinced it is a good idea to treat libgit.a as if it is a library. It is not a library in the usual sense of the word. Originally we did libgit.a primarily so that we do not have to list all the *.o dependencies in the Makefile out of laziness ;-) ``` ## Dmitry V. Levin, 2007-09-06 00:37 Subject: Re: [PATCH 3/3] Makefile: Add cache-tree.h to the public headers list Message-ID: <20070906003729.GB23887@basalt.office.altlinux.org> URL: https://gitlist.dev/e/20070906003729.GB23887%40basalt.office.altlinux.org In-Reply-To: <7vy7fkfy1c.fsf@gitster.siamese.dyndns.org> ``` On Wed, Sep 05, 2007 at 05:16:47PM -0700, Junio C Hamano wrote: [...] > I am however not convinced it is a good idea to treat libgit.a > as if it is a library. > It is not a library in the usual sense of the word. I'd certainly prefer libgit.so with stable interface instead, but parsecvs needs -lgit now, it cannot wait for "good library". -- ldv ```