threads / patch / 9763

patchverify-tag: also grok CR/LFs in the tag signature

Subject: [PATCH] verify-tag: also grok CR/LFs in the tag signature

## tl;dr

One message between Sep 3, 2007 and Sep 3, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Schindelin· Sep 3, 2007, 16:51 UTC · lore

On some people's favorite platform, gpg outputs signatures with CR/LF line endings. So verify-tag has to play nice with them.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	I just pushed a fix to 4msysgit.git which prevents the generation 
	of such tag signatures, but it's always better to be a little more 
	graceful.
	Note that the match less strict than before, but if you really 
	have to start a line in a signed tag with that magic BEGIN 
	PGP SIGNATURE string, you cannot be helped anyway.
 builtin-verify-tag.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Show changes to builtin-verify-tag.c +1 −1
diff --git a/builtin-verify-tag.c b/builtin-verify-tag.c
index 5c1314d..8cfefcf 100644
--- a/builtin-verify-tag.c
+++ b/builtin-verify-tag.c
@@ -35,7 +35,7 @@ static int run_gpg_verify(const char *buf, unsigned long size, int verbose)
 
 	/* find the length without signature */
 	len = 0;
-	while (len < size && prefixcmp(buf + len, PGP_SIGNATURE "\n")) {
+	while (len < size && prefixcmp(buf + len, PGP_SIGNATURE)) {
 		eol = memchr(buf + len, '\n', size - len);
 		len += eol ? eol - (buf + len) + 1 : size - len;
 	}
-- 
1.5.3.2.g46909

← back to recent threads