threads / patch / 9613

patchFix git-remote for ActiveState Perl

Subject: [PATCH] Fix git-remote for ActiveState Perl

## tl;dr

2 messages between Aug 22, 2007 and Aug 22, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Alex Riesen· Aug 22, 2007, 16:13 UTC · lore

For reason unknown a package in ActiveState Perl 5.8.7 must implement READLINE method differently for scalar and array context. The code tested to work for more sane and recent version of perl (5.8.8 shipped with Ubuntu), so maybe it was always a requirement.

Signed-off-by: Alex Riesen <raa.lkml@gmail.com>
---

Without this only the first remote can be used if you are unlucky enough to use that perl. There are probably more breakages, as only first line of a file/stream can be read. Not many use Git.pm on Windows and ActiveState Perl, so it went unnoticed for long time.

 perl/Git.pm |    8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

Show changes to perl/Git.pm +7 −1

diff --git a/perl/Git.pm b/perl/Git.pm
index 8fd3611..3f4080c 100644
--- a/perl/Git.pm
+++ b/perl/Git.pm
@@ -860,7 +860,13 @@ sub READLINE {
 	if ($self->{i} >= scalar @{$self->{data}}) {
 		return undef;
 	}
-	return $self->{'data'}->[ $self->{i}++ ];
+	my $i = $self->{i};
+	if (wantarray) {
+		$self->{i} = $#{$self->{'data'}} + 1;
+		return splice(@{$self->{'data'}}, $i);
+	}
+	$self->{i} = $i + 1;
+	return $self->{'data'}->[ $i ];
 }
 
 sub CLOSE {

-- 
1.5.3.rc6.19.g4d600f

Junio C Hamano· Aug 22, 2007, 20:19 UTC · re: Alex Riesen · lore

Re: [PATCH] Fix git-remote for ActiveState Perl

Alex Riesen <raa.lkml@gmail.com> writes:

> For reason unknown a package in ActiveState Perl 5.8.7 must implement
> READLINE method differently for scalar and array context. The code
> tested to work for more sane and recent version of perl (5.8.8 shipped
> with Ubuntu), so maybe it was always a requirement.

Well spotted.

Unfortunately, the manual perltie.pod is very sketchy on this issue, and only says:

    This method will be called when the handle is read from via <HANDLE>.
    The method should return undef when there is no more data.

The default implementation in Tie::StdHandle (Tie/Handle.pm) does agree with you by doing this:

    sub READLINE { my $fh = $_[0]; <$fh> }

So I am fairly confident that your patch is the right fix.

Interestingly, CPAN::Tarzip::READLINE (CPAN.pm) gets it wrong ;-) and caters only to calls in scalar context if I am reading the code correctly.

Thanks.  Will apply.