threads / patch / 9585

patchInstall man3 manpages to $PREFIX/share/man/man3 even for site installs

Subject: [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs

## tl;dr

3 messages between Aug 20, 2007 and Aug 23, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

martin f. krafft· Aug 20, 2007, 07:23 UTC · lore

Install section 3 manpages to .../share/man for consistency

When an admin installs git site-wide, e.g. to /usr/local, perl's makemaker decides to use 'site' mode (as opposed to distro or user mode). For whatever reason, it then installs all perl-related manpages (those in section 3) to .../man, while the rest of git happily installs manpages to .../share/man.

In as such, this is different from the patch proposed in this thread:
  http://marc.info/?t=117862141100003&r=1&w=2

My patch should only ever affect site installs and does not cause installations to $HOME to go to $HOME/share/...

martin f. krafft· Aug 20, 2007, 07:23 UTC · re: martin f. krafft · lore

MakeMaker supports three installation modes: perl, site, and vendor. The first and third install manpages to $PREFIX/share/man, only site installs to $PREFIX/man. For consistency with the rest of git, which does not make the distinction and writes all manpages to $PREFIX/share/man, this change makes sure that perl does too, even when it's installed in site mode.

Signed-off-by: martin f. krafft <madduck@madduck.net>
---
 perl/Makefile.PL |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Show changes to perl/Makefile.PL +1 −0

diff --git a/perl/Makefile.PL b/perl/Makefile.PL
index 4375161..6aecd89 100644
--- a/perl/Makefile.PL
+++ b/perl/Makefile.PL
@@ -29,5 +29,6 @@ WriteMakefile(
 	VERSION_FROM    => 'Git.pm',
 	PM		=> \%pm,
 	MAKEFILE	=> 'perl.mak',
+	INSTALLSITEMAN3DIR => '$(SITEPREFIX)/share/man/man3',
 	%extra
 );

-- 
1.5.3.rc5.40.g2f82

Junio C Hamano· Aug 23, 2007, 08:11 UTC · re: martin f. krafft · lore

Re: [PATCH] Install man3 manpages to $PREFIX/share/man/man3 even for site installs

Sorry for keeping you waiting for quite a while. I've had a chance to test building an RPM tonight, and this does not seem to affect the output (the perl manpage is already installed in /usr/share/man/man3), so I'd say this is probably safe to apply.

For people who do private installs, the path is changed from $prefix/man/man3/ to $prefix/share/man/man3 (where $prefix is typically set to $HOME), but all the other manual pages are installed in $prefix/share/man/man[1-7] anyway, so this change cannot hurt.