threads / discuss / 9545

Re: 1.5.3-rc5 regression on OS X?

Subject: Re: 1.5.3-rc5 regression on OS X?

## tl;dr

2 messages between Aug 15, 2007 and Aug 15, 2007.

replies: 1people: 2as markdown or json

Perrin Meyer· Aug 15, 2007, 22:52 UTC · lore

Well, this is my first time using git-bisect (which seems like a VERY cool tool), but iterating through, using $ make clean ; make -j 4 ; cd t ; sh t1000-read-tree-m-3way.sh ; cd ..

The first bad commit is:
933bf40a5c6328b6c022b636f45a6f2c48c3838e is first bad commit
commit 933bf40a5c6328b6c022b636f45a6f2c48c3838e
Author: Linus Torvalds <torvalds@linux-foundation.org>
Date:   Thu Aug 9 22:21:29 2007 -0700
    Start moving unpack-trees to "struct tree_desc"
    
    This doesn't actually change any real code, but it changes the interface
    to unpack_trees() to take an array of "struct tree_desc" entries, the same
    way the tree-walk.c functions do.
    
    The reason for this is that we would be much better off if we can do the
    tree-unpacking using the generic "traverse_trees()" functionality instead
    of having to the special "unpack" infrastructure.
    
    This really is a pretty minimal diff, just to change the calling
    convention. It passes all the tests, and looks sane. There were only two
    users of "unpack_trees()": builtin-read-tree and merge-recursive, and I
    tried to keep the changes minimal.
    
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>

:100644 100644 a3b17a3bd913d628d70ee625ec8b1808d3b200fa 1967d100f28d70e588fde618aa7ed4a10b76ee1d M builtin-read-tree.c :100644 100644 c8539ec0bafce5e238d97d6397a9d08c2c92a09c f7d1b84999d401887e4a4eba091d53f5fe7294c8 M merge-recursive.c :100644 100644 dfd985b0ef0193ce311ea77e8c8cb11fc7b1c3e3 5d1ffd1a32a56bdcf4f64b545abd6aa951914ffe M unpack-trees.c :100644 100644 fee7da43822b63e5b1f24444e5c51c43d3ff5760 9cd39a28a907ef6f0eedc764bbae586353ec2ca5 M unpack-trees.h

I'll install the newest Xcode and see if that fixes things. 
Perrin
----- Original Message ----
From: Junio C Hamano <gitster@pobox.com>
To: Perrin Meyer <perrinmeyer@yahoo.com>
Cc: git@vger.kernel.org
Sent: Wednesday, August 15, 2007 3:05:18 PM
Subject: Re: 1.5.3-rc5 regression on OS X?
Perrin Meyer <perrinmeyer@yahoo.com> writes:
> Nothing has changed,, I just did a git checkout v1.5.2.4; make clean; make ; make test, and that same test passes. Then I did a git checkout v1.5.3-rc5 ; make clean ; make ; make test, and the same test fails. 
>
> I'll try updating to a newer version of Xcode and see if that helps.

Before doing so, perhaps bisect between v1.5.2.4 and v1.5.3-rc5 woudl be very helpful.

Junio C Hamano· Aug 15, 2007, 22:59 UTC · re: Perrin Meyer · lore
Perrin Meyer <perrinmeyer@yahoo.com> writes:
Show 8 quoted lines
> Well, this is my first time using git-bisect (which seems like a VERY cool tool), but iterating through, using 
> $ make clean ; make -j 4 ; cd t ; sh t1000-read-tree-m-3way.sh ; cd ..
>
> The first bad commit is:
>
> 933bf40a5c6328b6c022b636f45a6f2c48c3838e is first bad commit
> ...
> I'll install the newest Xcode and see if that fixes things.

Thanks, but before doing so could you try the patch I just sent out?

← back to recent threads