threads / patch / 9448

patchcvsserver: Fix for work trees

Subject: [PATCH] cvsserver: Fix for work trees

## tl;dr

3 messages between Aug 9, 2007 and Aug 9, 2007. Diffs are folded; open one to read it.

replies: 2people: 3as markdown or json

Brian Downing· Aug 9, 2007, 04:26 UTC · lore

git-cvsserver used checkout-index internally for commit and annotate. Since a work tree is required for this to function now, this was breaking. Work around this by defining GIT_WORK_TREE=. in the appropriate places.

Signed-off-by: Brian Downing <bdowning@lavos.net>
---
 git-cvsserver.perl |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to git-cvsserver.perl +2 −0
diff --git a/git-cvsserver.perl b/git-cvsserver.perl
index ae7d511..13dbd27 100755
--- a/git-cvsserver.perl
+++ b/git-cvsserver.perl
@@ -1196,6 +1196,7 @@ sub req_ci
     $log->info("Lockless commit start, basing commit on '$tmpdir', index file is '$file_index'");
 
     $ENV{GIT_DIR} = $state->{CVSROOT} . "/";
+    $ENV{GIT_WORK_TREE} = ".";
     $ENV{GIT_INDEX_FILE} = $file_index;
 
     # Remember where the head was at the beginning.
@@ -1721,6 +1722,7 @@ sub req_annotate
     $log->info("Temp checkoutdir creation successful, basing annotate session work on '$tmpdir', index file is '$file_index'");
 
     $ENV{GIT_DIR} = $state->{CVSROOT} . "/";
+    $ENV{GIT_WORK_TREE} = ".";
     $ENV{GIT_INDEX_FILE} = $file_index;
 
     chdir $tmpdir;

-- 
1.5.3.GIT
Junio C Hamano· Aug 9, 2007, 05:45 UTC · re: Brian Downing · lore

Re: [PATCH] cvsserver: Fix for work trees

Hmmmmm....

This is a good fix to adjust to the new world order introduced by Dscho's rewrite of work-tree stuff, where the rules are:

 * When GIT_DIR is set and GIT_WORK_TREE is not, GIT_DIR is used
   to read config file, to figure out core.worktree.  When
   core.worktree is not set, a complicated algorithm is used to
   figure out the top of the working tree based on the value of
   GIT_DIR, and this can sometimes figure out that you are in a
   subdirectory of the working tree.  In such a case, you are in
   the working tree, but not necessarily at the top.
 * Otherwise, commands that require to have working tree now
   barf.  Earlier they always and consistently treated that your
   $cwd is the top of working tree and did not barf.

This new world order is probably an improvement, and if the rules were like this from the beginning, it would have been much nicer. However, this _is_ a change of semantics in the middle of the road, and probably we will see many fallouts like this. Unfortunate... I am torn between a cleaner semantics and the short-term pain...

Johannes Schindelin· Aug 9, 2007, 08:45 UTC · re: Junio C Hamano · lore

Re: [PATCH] cvsserver: Fix for work trees

Hi,
On Wed, 8 Aug 2007, Junio C Hamano wrote:
Show 5 quoted lines
> This new world order is probably an improvement, and if the rules were 
> like this from the beginning, it would have been much nicer.  However, 
> this _is_ a change of semantics in the middle of the road, and probably 
> we will see many fallouts like this.  Unfortunate...  I am torn between 
> a cleaner semantics and the short-term pain...

With your warning at the beginning of the ReleaseNotes, I think it would be the same amount of pain if we did it later. It just would be... later.

Ciao, Dscho

← back to recent threads