threads / patch / 9414

patchgit checkout's reflog: even when detaching the HEAD, say from where

Subject: [PATCH] git checkout's reflog: even when detaching the HEAD, say from where

## tl;dr

2 messages between Aug 7, 2007 and Aug 7, 2007. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Johannes Schindelin· Aug 7, 2007, 01:42 UTC · lore

When checking out another ref, the reflogs already record from which branch you switched. Do that also when switching to a detached HEAD.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 git-checkout.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

Show changes to git-checkout.sh +2 −1

diff --git a/git-checkout.sh b/git-checkout.sh
index 17f4392..f427718 100755
--- a/git-checkout.sh
+++ b/git-checkout.sh
@@ -272,7 +272,8 @@ if [ "$?" -eq 0 ]; then
 		fi
 	elif test -n "$detached"
 	then
-		git update-ref --no-deref -m "checkout: moving to $arg" HEAD "$detached" ||
+		old_branch_name=`expr "z$oldbranch" : 'zrefs/heads/\(.*\)'`
+		git update-ref --no-deref -m "checkout: moving from $old_branch_name to $arg" HEAD "$detached" ||
 			die "Cannot detach HEAD"
 		if test -n "$detach_warn"
 		then

-- 
1.5.3.rc4.17.gb980

Junio C Hamano· Aug 7, 2007, 03:56 UTC · re: Johannes Schindelin · lore

Re: [PATCH] git checkout's reflog: even when detaching the HEAD, say from where

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 7 quoted lines

> @@ -272,7 +272,8 @@ if [ "$?" -eq 0 ]; then
>  		fi
>  	elif test -n "$detached"
>  	then
> -		git update-ref --no-deref -m "checkout: moving to $arg" HEAD "$detached" ||
> +		old_branch_name=`expr "z$oldbranch" : 'zrefs/heads/\(.*\)'`
> +		git update-ref --no-deref -m "checkout: moving from $old_branch_name to $arg" HEAD "$detached" ||

Can't old_branch_name be empty here if you are already detached?

Show 5 quoted lines

>  			die "Cannot detach HEAD"
>  		if test -n "$detach_warn"
>  		then
> -- 
> 1.5.3.rc4.17.gb980