# [PATCH] Mention libiconv as a requirement for git-am 4 messages from 2007-07-31 to 2007-08-01. Participants: Nguyen Thai Ngoc Duy, Han-Wen Nienhuys. Thread: https://gitlist.dev/t/9329 ## Nguyen Thai Ngoc Duy, 2007-07-31 15:09 Subject: [PATCH] Mention libiconv as a requirement for git-am Message-ID: <20070731150948.GA9947@localhost> URL: https://gitlist.dev/e/20070731150948.GA9947%40localhost ``` --- Han-Wen, any chance to include libiconv to the installer? You may need to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work. README.MinGW | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/README.MinGW b/README.MinGW index 89b7065..c0b8f66 100644 --- a/README.MinGW +++ b/README.MinGW @@ -28,6 +28,7 @@ In order to compile this code you need: zlib-1.2.3-mingwPORT-1.tar w32api-3.6.tar.gz tcltk-8.4.1-1.exe (for gitk, git-gui) + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) STATUS -- 1.5.0.7 ``` ## Han-Wen Nienhuys, 2007-08-01 03:03 Subject: Re: [PATCH] Mention libiconv as a requirement for git-am Message-ID: URL: https://gitlist.dev/e/f329bf540707312003i60e910e9kf97d2f50fdecbed2%40mail.gmail.com In-Reply-To: <20070731150948.GA9947@localhost> ``` libiconv is already in there, version 1.11, [lilydev@haring gub]$ grep bin.libiconv target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt \usr\bin\libiconv-2.dll I don't understand your request: do you want to have some flags added to the environment? 2007/7/31, Nguyen Thai Ngoc Duy : > --- > Han-Wen, any chance to include libiconv to the installer? You may need > to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work. > > README.MinGW | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/README.MinGW b/README.MinGW > index 89b7065..c0b8f66 100644 > --- a/README.MinGW > +++ b/README.MinGW > @@ -28,6 +28,7 @@ In order to compile this code you need: > zlib-1.2.3-mingwPORT-1.tar > w32api-3.6.tar.gz > tcltk-8.4.1-1.exe (for gitk, git-gui) > + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) > > > STATUS > -- > 1.5.0.7 > -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen ``` ## Nguyen Thai Ngoc Duy, 2007-08-01 03:18 Subject: Re: [PATCH] Mention libiconv as a requirement for git-am Message-ID: URL: https://gitlist.dev/e/fcaeb9bf0707312018p25297d76g50489fa303856dd6%40mail.gmail.com In-Reply-To: ``` I'm sorry I judged by reading Makefile without actually testing your installation, so I might be wrong. By default Makefile set NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in config.mak in order to enable it. I'm going to test it tomorrow. On 7/31/07, Han-Wen Nienhuys wrote: > libiconv is already in there, version 1.11, > > [lilydev@haring gub]$ grep bin.libiconv > target/mingw/gubfiles/installer-git-master-repo.or.cz-git-mingw.git/files.txt > \usr\bin\libiconv-2.dll > > I don't understand your request: do you want to have some flags added > to the environment? > > 2007/7/31, Nguyen Thai Ngoc Duy : > > --- > > Han-Wen, any chance to include libiconv to the installer? You may need > > to set NEEDS_ICONV, ICONVDIR and NO_ICONV properly to make git-am work. > > > > README.MinGW | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/README.MinGW b/README.MinGW > > index 89b7065..c0b8f66 100644 > > --- a/README.MinGW > > +++ b/README.MinGW > > @@ -28,6 +28,7 @@ In order to compile this code you need: > > zlib-1.2.3-mingwPORT-1.tar > > w32api-3.6.tar.gz > > tcltk-8.4.1-1.exe (for gitk, git-gui) > > + libiconv-1.9.2-1-{lib,bin}.zip (for git-am, from http://gnuwin32.sourceforge.net/packages/libiconv.htm) > > > > > > STATUS > > -- > > 1.5.0.7 > > > > > -- > Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen > -- Duy ``` ## Han-Wen Nienhuys, 2007-08-01 03:36 Subject: Re: [PATCH] Mention libiconv as a requirement for git-am Message-ID: URL: https://gitlist.dev/e/f329bf540707312036v26e553d6n2b0f99e53ca0aabb%40mail.gmail.com In-Reply-To: ``` 2007/8/1, Nguyen Thai Ngoc Duy : > I'm sorry I judged by reading Makefile without actually testing your > installation, so I might be wrong. By default Makefile set > NO_ICONV=YesPlease on MinGW so it won't use libiconv even if it > exists. You need to unset NO_ICONV and set NEEDS_LIBICONV in > config.mak in order to enable it. this is done automatically when running configure. If you find a problem with the installer please let me know. > I'm going to test it tomorrow. -- Han-Wen Nienhuys - hanwen@xs4all.nl - http://www.xs4all.nl/~hanwen ```