threads / patch / 9328

patch, 4 partsFix allocation of "int*" instead of "int".

Subject: [PATCH 1/4] Fix allocation of "int*" instead of "int".

## tl;dr

3 messages between Jul 31, 2007 and Aug 1, 2007. Diffs are folded; open one to read it.

replies: 2people: 2as markdown or json

Christian Couder· Jul 31, 2007, 12:48 UTC · lore

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
---

 While working on something like a "git bisect dunno", I came up with
 the patches in this series.

 Thanks in advance,
 Christian.

 builtin-rev-list.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Show changes to builtin-rev-list.c +1 −1

diff --git a/builtin-rev-list.c b/builtin-rev-list.c
index 8efd609..5bcafe4 100644
--- a/builtin-rev-list.c
+++ b/builtin-rev-list.c
@@ -300,7 +300,7 @@ static struct commit_list *find_bisection(struct commit_list *list,
 	show_list("bisection 2 sorted", 0, nr, list);
 
 	*all = nr;
-	weights = xcalloc(on_list, sizeof(int*));
+	weights = xcalloc(on_list, sizeof(int));
 	counted = 0;
 
 	for (n = 0, p = list; p; p = p->next) {

-- 
1.5.2.1.144.gabc40

Jeff King· Jul 31, 2007, 19:56 UTC · re: Christian Couder · lore

Re: [PATCH 1/4] Fix allocation of "int*" instead of "int".

On Tue, Jul 31, 2007 at 02:48:29PM +0200, Christian Couder wrote:

> -	weights = xcalloc(on_list, sizeof(int*));
> +	weights = xcalloc(on_list, sizeof(int));

How about the correct-by-definition sizeof(*weights)?

-Peff

Christian Couder· Aug 1, 2007, 04:11 UTC · re: Jeff King · lore

Re: [PATCH 1/4] Fix allocation of "int*" instead of "int".

Le mardi 31 juillet 2007 21:56, Jeff King a écrit :

Show 5 quoted lines

> On Tue, Jul 31, 2007 at 02:48:29PM +0200, Christian Couder wrote:
> > -	weights = xcalloc(on_list, sizeof(int*));
> > +	weights = xcalloc(on_list, sizeof(int));
>
> How about the correct-by-definition sizeof(*weights)?

That's ok for me too.

Thanks, Christian.