threads / patch / 9229

patchgit-write-tree should not crash if prefix does not exist

Subject: [PATCH] git-write-tree should not crash if prefix does not exist

## tl;dr

One message between Jul 26, 2007 and Jul 26, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Nguyễn Thái Ngọc Duy· Jul 26, 2007, 03:14 UTC · lore
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
---
 Resend as it seems git-send-email and vger.kernel.org don't like me
 much
 builtin-write-tree.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to builtin-write-tree.c +2 −0
diff --git a/builtin-write-tree.c b/builtin-write-tree.c
index 391de53..88f34ba 100644
--- a/builtin-write-tree.c
+++ b/builtin-write-tree.c
@@ -52,6 +52,8 @@ int write_tree(unsigned char *sha1, int missing_ok, const char *prefix)
 	if (prefix) {
 		struct cache_tree *subtree =
 			cache_tree_find(active_cache_tree, prefix);
+		if (!subtree)
+			die("git-write-tree: prefix %s not found", prefix);
 		hashcpy(sha1, subtree->sha1);
 	}
 	else
-- 
1.5.2

← back to recent threads