threads / patch / 9191

patchmailinfo: fix 'fatal: cannot convert from utf-8 to utf-8'

Subject: [PATCH] mailinfo: fix 'fatal: cannot convert from utf-8 to utf-8'

## tl;dr

One message between Jul 24, 2007 and Jul 24, 2007. Diffs are folded; open one to read it.

replies: 0people: 1as markdown or json

Johannes Schindelin· Jul 24, 2007, 00:03 UTC · lore

For some reason, I got this error message. Maybe it does not make sense, but then we should not really try to convert the text when it is not necessary.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
	This bit me when I tried to apply the most recent Japanese 
	translation patch to git-gui-i18n.
 builtin-mailinfo.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
Show changes to builtin-mailinfo.c +2 −0
diff --git a/builtin-mailinfo.c b/builtin-mailinfo.c
index a37a4ff..b4f6e91 100644
--- a/builtin-mailinfo.c
+++ b/builtin-mailinfo.c
@@ -529,6 +529,8 @@ static void convert_to_utf8(char *line, const char *charset)
 			return;
 	}
 
+	if (!strcmp(metainfo_charset, charset))
+		return;
 	out = reencode_string(line, metainfo_charset, charset);
 	if (!out)
 		die("cannot convert from %s to %s\n",
-- 
1.5.3.rc2.32.g35c5b-dirty

← back to recent threads